[Issue 11473] [Python] Fix fields that are ignoring the required key argument #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to replay the CI pipeline? |
|
/pulsarbot run-failure-checks |
sijie
approved these changes
Aug 4, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Aug 4, 2021
… argument (#11508) Fixes #11473 ### Motivation By default, classes that inherit from Fields have a `required` key argument which is False. If an attribute is not declared with a value, an exception is raised. ```python Invalid type '<class' NoneType '>' for field 'name'. Expected a string ``` ### Modifications The modifications made affect 2 classes: Field and String. In both cases, the `validate_type` method has been modified to take into account arguments inherited from the Field class, including` required` and `default`. Validation looks to see if the field is required. If it is not required (`required=False`) and the value does not exist, the default value is returned. This modification removes the error and allows to integrate the different types of fields based on the definition of the key arguments of the Field class (cherry picked from commit b80b0be)
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Aug 5, 2021
… argument (#11508) Fixes #11473 ### Motivation By default, classes that inherit from Fields have a `required` key argument which is False. If an attribute is not declared with a value, an exception is raised. ```python Invalid type '<class' NoneType '>' for field 'name'. Expected a string ``` ### Modifications The modifications made affect 2 classes: Field and String. In both cases, the `validate_type` method has been modified to take into account arguments inherited from the Field class, including` required` and `default`. Validation looks to see if the field is required. If it is not required (`required=False`) and the value does not exist, the default value is returned. This modification removes the error and allows to integrate the different types of fields based on the definition of the key arguments of the Field class (cherry picked from commit b80b0be)
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
… argument (apache#11508) Fixes apache#11473 ### Motivation By default, classes that inherit from Fields have a `required` key argument which is False. If an attribute is not declared with a value, an exception is raised. ```python Invalid type '<class' NoneType '>' for field 'name'. Expected a string ``` ### Modifications The modifications made affect 2 classes: Field and String. In both cases, the `validate_type` method has been modified to take into account arguments inherited from the Field class, including` required` and `default`. Validation looks to see if the field is required. If it is not required (`required=False`) and the value does not exist, the default value is returned. This modification removes the error and allows to integrate the different types of fields based on the definition of the key arguments of the Field class
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
… argument (apache#11508) Fixes apache#11473 ### Motivation By default, classes that inherit from Fields have a `required` key argument which is False. If an attribute is not declared with a value, an exception is raised. ```python Invalid type '<class' NoneType '>' for field 'name'. Expected a string ``` ### Modifications The modifications made affect 2 classes: Field and String. In both cases, the `validate_type` method has been modified to take into account arguments inherited from the Field class, including` required` and `default`. Validation looks to see if the field is required. If it is not required (`required=False`) and the value does not exist, the default value is returned. This modification removes the error and allows to integrate the different types of fields based on the definition of the key arguments of the Field class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11473
Motivation
By default, classes that inherit from Fields have a
requiredkey argument which is False.If an attribute is not declared with a value, an exception is raised.
Modifications
The modifications made affect 2 classes: Field and String. In both cases, the
validate_typemethod has been modified to take into account arguments inherited from the Field class, includingrequiredanddefault.Validation looks to see if the field is required. If it is not required (
required=False) and the value does not exist, the default value is returned.This modification removes the error and allows to integrate the different types of fields based on the definition of the key arguments of the Field class
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Documentation
For commiter
No documentation update is required.
The implementation of any fields is not include in the documentation.