[Issue 11558][Python] Check if the record is not None #11559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11558
Motivation
Not all sub-records are required in a schema. Taking this context into account, the code of the Record class ignored its own default values (
required=False
anddefault=None
)Modifications
The modification is a continuation of the ones made in the PR #11508.
This time only the
Record
class has changed. The modification affects the validation. A check of the value and therequired
attribute is done before validating the data type.So if the value is empty and the
required
is False, the default is returned instead of raising an exception.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For contributor
No documentation update is required.
The definition of the
Record
class wasn't respectedFor committer
For this PR, do we need to update docs?
No