Fixed Proxy leaking oubound connections #11848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
addisonj,
rdhabalia,
jerrypeng,
hangc0276,
jiazhai and
codelipenghui
codelipenghui
approved these changes
Aug 31, 2021
hangc0276
approved these changes
Aug 31, 2021
merlimat
added a commit
that referenced
this pull request
Aug 31, 2021
merlimat
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 1, 2021
(cherry picked from commit af63e96)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the refactoring done in #10028, there's a leak of outgoing TCP connection in the Pulsar proxy.
The problem is that the
ProxyConnectionPoolinstances are now marked as created outside thePulsarClientImplinstance and therefore not closed when the client is closed.Modification
Make sure we shutdown the
ConnectionPool.This is not easily testable in unit tests. Instead this class of issue should be tested for in system tests.