Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulsar-functions-go] support set subscription position #11990

Merged
merged 2 commits into from
Sep 24, 2021
Merged

[pulsar-functions-go] support set subscription position #11990

merged 2 commits into from
Sep 24, 2021

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Sep 10, 2021 •
edited
Loading

Motivation

Support pass subscription position to pulsar-functions-go

Modifications

  • add subscription position in go instance conf
  • process subscription position in go function

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

will add related doc in separate PR

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet added this to the 2.9.0 milestone Sep 10, 2021
@freeznet freeznet self-assigned this Sep 10, 2021
@Anonymitaet Anonymitaet added the doc-required Your PR changes impact docs and you will update later. label Sep 10, 2021
@Anonymitaet
Copy link
Member

@freeznet Thanks for your contribution. Please do not forget to update docs later. And you can ping me to review the docs, thanks.

@sijie
Copy link
Member

sijie commented Sep 17, 2021

@nlu90 please review it.

nlu90
nlu90 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@nlu90 nlu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freeznet freeznet merged commit 652d154 into apache:master Sep 24, 2021
codelipenghui pushed a commit that referenced this pull request Sep 24, 2021
@freeznet @codelipenghui
[pulsar-functions-go] support set subscription position (#11990)
d5d40a2 
* stash

* set default value

(cherry picked from commit 652d154)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 24, 2021
@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-required Your PR changes impact docs and you will update later. labels Oct 15, 2021
@Anonymitaet
Copy link
Member

Doc has been added
image

bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@freeznet @ciaocloud
[pulsar-functions-go] support set subscription position (apache#11990)
9c2d24d 
* stash

* set default value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@nlu90 nlu90 nlu90 approved these changes

@wolfstudy wolfstudy Awaiting requested review from wolfstudy

Assignees

@freeznet freeznet

Labels
area/function cherry-picked/branch-2.8 Archived: 2.8 is end of life doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/2.8.2 release/2.9.0
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freeznet @Anonymitaet @sijie @nlu90 @eolivelli @codelipenghui