Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong key-hash selector used for new consumers after all the previous consumers disconnected #12035

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

codelipenghui
Copy link
Contributor

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy

…ious consumers disconnected

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after new consumer with different key-shared policy
@codelipenghui codelipenghui self-assigned this Sep 14, 2021
@codelipenghui codelipenghui added release/2.7.4 release/2.8.2 doc-not-needed Your PR changes do not impact docs labels Sep 14, 2021
@codelipenghui codelipenghui added this to the 2.9.0 milestone Sep 14, 2021
syhily added a commit to streamnative/flink that referenced this pull request Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
dawidwys pushed a commit to apache/flink that referenced this pull request Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
dawidwys pushed a commit to apache/flink that referenced this pull request Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
@sijie sijie merged commit 3a4755f into apache:master Sep 17, 2021
eolivelli pushed a commit to datastax/pulsar that referenced this pull request Sep 17, 2021
…ious consumers disconnected (apache#12035)

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy

(cherry picked from commit 3a4755f)
@codelipenghui codelipenghui deleted the penghui/fix-key-shared-selector branch September 18, 2021 07:03
codelipenghui added a commit that referenced this pull request Sep 18, 2021
…ious consumers disconnected (#12035)

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy

(cherry picked from commit 3a4755f)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 18, 2021
jianyun8023 pushed a commit to streamnative/flink that referenced this pull request Sep 22, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
codelipenghui added a commit that referenced this pull request Dec 11, 2021
…ious consumers disconnected (#12035)

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy

(cherry picked from commit 3a4755f)
@codelipenghui codelipenghui added cherry-picked/branch-2.9 Archived: 2.9 is end of life and removed cherry-picked/branch-2.9 Archived: 2.9 is end of life labels Dec 11, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Dec 11, 2021
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…ious consumers disconnected (apache#12035)

We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.

The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy
@codelipenghui codelipenghui restored the penghui/fix-key-shared-selector branch May 17, 2022 01:22
@codelipenghui codelipenghui deleted the penghui/fix-key-shared-selector branch May 17, 2022 01:29
MartijnVisser pushed a commit to MartijnVisser/flink-connector-pulsar that referenced this pull request Nov 28, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
MartijnVisser pushed a commit to MartijnVisser/flink-connector-pulsar that referenced this pull request Nov 29, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
MartijnVisser pushed a commit to apache/flink-connector-pulsar that referenced this pull request Nov 29, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
lzshlzsh pushed a commit to lzshlzsh/oceanus-flink-connectors that referenced this pull request Apr 11, 2023
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer.

This fix apache/pulsar#12035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.7 Archived: 2.7 is end of life cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.7.4 release/2.8.2 release/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants