-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong key-hash selector used for new consumers after all the previous consumers disconnected #12035
Merged
sijie
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-key-shared-selector
Sep 17, 2021
Merged
Fix wrong key-hash selector used for new consumers after all the previous consumers disconnected #12035
sijie
merged 1 commit into
apache:master
from
codelipenghui:penghui/fix-key-shared-selector
Sep 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious consumers disconnected We will encounter the issue after all the previous consumers disconnected and the new consumers connect to the topic with different key_shared policy. The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix is to use a new dispatcher after new consumer with different key-shared policy
syhily
added a commit
to streamnative/flink
that referenced
this pull request
Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
dawidwys
pushed a commit
to apache/flink
that referenced
this pull request
Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
dawidwys
pushed a commit
to apache/flink
that referenced
this pull request
Sep 14, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
BewareMyPower
approved these changes
Sep 16, 2021
sijie
approved these changes
Sep 17, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 17, 2021
…ious consumers disconnected (apache#12035) We will encounter the issue after all the previous consumers disconnected and the new consumers connect to the topic with different key_shared policy. The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix is to use a new dispatcher after a new consumer with a different key-shared policy (cherry picked from commit 3a4755f)
codelipenghui
added a commit
that referenced
this pull request
Sep 18, 2021
…ious consumers disconnected (#12035) We will encounter the issue after all the previous consumers disconnected and the new consumers connect to the topic with different key_shared policy. The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix is to use a new dispatcher after a new consumer with a different key-shared policy (cherry picked from commit 3a4755f)
jianyun8023
pushed a commit
to streamnative/flink
that referenced
this pull request
Sep 22, 2021
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
codelipenghui
added a commit
that referenced
this pull request
Dec 11, 2021
…ious consumers disconnected (#12035) We will encounter the issue after all the previous consumers disconnected and the new consumers connect to the topic with different key_shared policy. The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix is to use a new dispatcher after a new consumer with a different key-shared policy (cherry picked from commit 3a4755f)
niklassemmler
pushed a commit
to niklassemmler/flink
that referenced
this pull request
Feb 3, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…ious consumers disconnected (apache#12035) We will encounter the issue after all the previous consumers disconnected and the new consumers connect to the topic with different key_shared policy. The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix is to use a new dispatcher after a new consumer with a different key-shared policy
MartijnVisser
pushed a commit
to MartijnVisser/flink-connector-pulsar
that referenced
this pull request
Nov 28, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
MartijnVisser
pushed a commit
to MartijnVisser/flink-connector-pulsar
that referenced
this pull request
Nov 29, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
MartijnVisser
pushed a commit
to apache/flink-connector-pulsar
that referenced
this pull request
Nov 29, 2022
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
lzshlzsh
pushed a commit
to lzshlzsh/oceanus-flink-connectors
that referenced
this pull request
Apr 11, 2023
…subscription. This would make sure Pulsar won't treat the flink reader as a shared consumer. This fix apache/pulsar#12035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.7
Archived: 2.7 is end of life
cherry-picked/branch-2.8
Archived: 2.8 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.7.4
release/2.8.2
release/2.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will encounter the issue after all the previous consumers disconnected and the new consumers connect
to the topic with different key_shared policy.
The root cause is we are using the previous dispatcher after the key_shared policy changed, so the fix
is to use a new dispatcher after a new consumer with a different key-shared policy