Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JLine 2.x for ZK CLI tool #12102

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Added JLine 2.x for ZK CLI tool #12102

merged 1 commit into from
Sep 23, 2021

Conversation

merlimat
Copy link
Contributor

Motivation

Added the JLine dependency into binary distribution so that the zookeeper-shell command will be easier to use with completion/history/etc..

@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages doc-not-needed Your PR changes do not impact docs labels Sep 20, 2021
@merlimat merlimat added this to the 2.9.0 milestone Sep 20, 2021
@merlimat merlimat self-assigned this Sep 20, 2021
@merlimat merlimat assigned hangc0276 and unassigned hangc0276 Sep 22, 2021
eolivelli
eolivelli approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 69cc7a7 into apache:master Sep 23, 2021
@merlimat merlimat deleted the jline branch September 23, 2021 15:47
@shoothzj shoothzj mentioned this pull request Sep 24, 2021
Closed
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@merlimat @ciaocloud
Added JLine 2.x for ZK CLI tool (apache#12102)
b916140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@eolivelli eolivelli eolivelli approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@merlimat merlimat

Labels
doc-not-needed Your PR changes do not impact docs release/2.9.0 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@merlimat @hangc0276 @eolivelli