Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unit test] use correct line separator instead of \n #12143

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

shoothzj
Copy link
Member

Motivation

The unit test use \n, it can only paas in linux and OSX, can't run on windows.

Modifications

use System line separator instead of \n

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

a little enhance, doesn't need doc

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Sep 23, 2021
@shoothzj
Copy link
Member Author

@sijie @codelipenghui @BewareMyPower PTAL

@shoothzj shoothzj closed this Sep 23, 2021
@shoothzj shoothzj reopened this Sep 23, 2021
@shoothzj
Copy link
Member Author

@merlimat @eolivelli PTAL

@merlimat merlimat merged commit 3033ac8 into apache:master Sep 23, 2021
@shoothzj shoothzj deleted the windows-llt-line-seoaratir branch September 23, 2021 05:34
codelipenghui pushed a commit that referenced this pull request Sep 24, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Sep 24, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants