Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant parameters #12188

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

lordcheng10
Copy link
Contributor

@lordcheng10 lordcheng10 commented Sep 25, 2021

In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant and not used。

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Sep 26, 2021
@lordcheng10
Copy link
Contributor Author

@eolivelli, @codelipenghui, @BewareMyPower, @sijie, @hangc0276, @merlimat - PTAL, thanks.

@BewareMyPower BewareMyPower added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Sep 28, 2021
@BewareMyPower BewareMyPower added this to the 2.9.0 milestone Sep 28, 2021
@michaeljmarshall
Copy link
Member

@lordcheng10, you can trigger CI to rerun failed tests by posting a comment with the following message:

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

Thanks!

@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@lordcheng10
Copy link
Contributor Author

/pulsarbot run-failure-checks

@lordcheng10
Copy link
Contributor Author

lordcheng10 commented Sep 29, 2021

@BewareMyPower @michaeljmarshall PTAL ,thanks!

@aahmed-se aahmed-se merged commit bef306c into apache:master Sep 29, 2021
codelipenghui pushed a commit that referenced this pull request Oct 6, 2021
* In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant

* Trigger CICD

* Trigger CICD

(cherry picked from commit bef306c)
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Oct 6, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
* In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant

* Trigger CICD

* Trigger CICD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.2 release/2.9.0 type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants