-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant parameters #12188
Merged
aahmed-se
merged 3 commits into
apache:master
from
lordcheng10:remove_redundant_parameters
Sep 29, 2021
Merged
remove redundant parameters #12188
aahmed-se
merged 3 commits into
apache:master
from
lordcheng10:remove_redundant_parameters
Sep 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages is redundant
michaeljmarshall
approved these changes
Sep 27, 2021
@eolivelli, @codelipenghui, @BewareMyPower, @sijie, @hangc0276, @merlimat - PTAL, thanks. |
BewareMyPower
approved these changes
Sep 28, 2021
@lordcheng10, you can trigger CI to rerun failed tests by posting a comment with the following message:
|
Thanks! |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
@BewareMyPower @michaeljmarshall PTAL ,thanks! |
aahmed-se
approved these changes
Sep 29, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Oct 6, 2021
* In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant * Trigger CICD * Trigger CICD (cherry picked from commit bef306c)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant * Trigger CICD * Trigger CICD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-2.8
Archived: 2.8 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.8.2
release/2.9.0
type/cleanup
Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the method internalConsumerFlow, the parameter additionalNumberOfMessages is redundant and not used。