Allow Pulsar Functions localrun to exit on error #12278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2021 23:18
aahmed-se
approved these changes
Oct 5, 2021
merlimat
approved these changes
Oct 6, 2021
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 4, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit cd9356a)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 4, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit cd9356a)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit cd9356a)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit cd9356a)
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Mar 7, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com> (cherry picked from commit cd9356a)
4 tasks
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Co-authored-by: Jerry Peng <jerryp@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are situations where it is useful for localrun to exit if the instance it is running encounters an error. This is useful for situations where the localrun is being orchestrated by a scheduler like K8s. If there are errors in the function, it is easier to detect, observe, and alert on issues if the localrun is consisting exiting / crash loop.
Modifications
Verifying this change
Add tests.