[Managed Ledger] Fix the incorrect total size when BrokerEntryMetadata is enabled #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
doc-not-needed
BewareMyPower
requested review from
codelipenghui,
eolivelli,
rdhabalia,
hangc0276 and
merlimat
Can we update the dataLength when calling setData()? We might get different value by readableBytes() which there is a reader read the data from the buffer. |
+1 |
|
@codelipenghui @eolivelli done. |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 11, 2021
…a is enabled (apache#12714) ### Motivation When the BrokerEntryMetadata is enabled, the total size in `ManagedLedgerImpl` is inaccurate. Because when the total size is updated in `OpAddEntry#safeRun`, the `dataLength` is the initial size of `data` when `OpAddEntry` is constructed, but `data` could be changed via `setData` method. The inaccurate total size could affect the retention size validation. Because in `ManagedLedgerImpl#internalTrimLedgers`, the total size reduces by the size of `LedgerInfo`, which is assigned from the `LedgerHandle#getLength()`. Therefore, the total size will become 0 or less before all ledgers are removed. ### Modifications - Update `dataLength` field in `setData` method. - Add a `testManagedLedgerTotalSize` test to `BrokerEntryMetadataE2ETest`. It produces 10 messages and trigger the rollover manually so that the first `LedgerInfo` of the managed ledger contains the correct total bytes. Then compare the `totalSize` field with it to verify this fix works. (cherry picked from commit 5dbb7d2)
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
…a is enabled (#12714) ### Motivation When the BrokerEntryMetadata is enabled, the total size in `ManagedLedgerImpl` is inaccurate. Because when the total size is updated in `OpAddEntry#safeRun`, the `dataLength` is the initial size of `data` when `OpAddEntry` is constructed, but `data` could be changed via `setData` method. The inaccurate total size could affect the retention size validation. Because in `ManagedLedgerImpl#internalTrimLedgers`, the total size reduces by the size of `LedgerInfo`, which is assigned from the `LedgerHandle#getLength()`. Therefore, the total size will become 0 or less before all ledgers are removed. ### Modifications - Update `dataLength` field in `setData` method. - Add a `testManagedLedgerTotalSize` test to `BrokerEntryMetadataE2ETest`. It produces 10 messages and trigger the rollover manually so that the first `LedgerInfo` of the managed ledger contains the correct total bytes. Then compare the `totalSize` field with it to verify this fix works. (cherry picked from commit 5dbb7d2)
codelipenghui
added
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…a is enabled (apache#12714) ### Motivation When the BrokerEntryMetadata is enabled, the total size in `ManagedLedgerImpl` is inaccurate. Because when the total size is updated in `OpAddEntry#safeRun`, the `dataLength` is the initial size of `data` when `OpAddEntry` is constructed, but `data` could be changed via `setData` method. The inaccurate total size could affect the retention size validation. Because in `ManagedLedgerImpl#internalTrimLedgers`, the total size reduces by the size of `LedgerInfo`, which is assigned from the `LedgerHandle#getLength()`. Therefore, the total size will become 0 or less before all ledgers are removed. ### Modifications - Update `dataLength` field in `setData` method. - Add a `testManagedLedgerTotalSize` test to `BrokerEntryMetadataE2ETest`. It produces 10 messages and trigger the rollover manually so that the first `LedgerInfo` of the managed ledger contains the correct total bytes. Then compare the `totalSize` field with it to verify this fix works.
eolivelli
pushed a commit
that referenced
this pull request
Dec 15, 2021
…a is enabled (#12714) ### Motivation When the BrokerEntryMetadata is enabled, the total size in `ManagedLedgerImpl` is inaccurate. Because when the total size is updated in `OpAddEntry#safeRun`, the `dataLength` is the initial size of `data` when `OpAddEntry` is constructed, but `data` could be changed via `setData` method. The inaccurate total size could affect the retention size validation. Because in `ManagedLedgerImpl#internalTrimLedgers`, the total size reduces by the size of `LedgerInfo`, which is assigned from the `LedgerHandle#getLength()`. Therefore, the total size will become 0 or less before all ledgers are removed. ### Modifications - Update `dataLength` field in `setData` method. - Add a `testManagedLedgerTotalSize` test to `BrokerEntryMetadataE2ETest`. It produces 10 messages and trigger the rollover manually so that the first `LedgerInfo` of the managed ledger contains the correct total bytes. Then compare the `totalSize` field with it to verify this fix works. (cherry picked from commit 5dbb7d2)
codelipenghui
added
cherry-picked/branch-2.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the BrokerEntryMetadata is enabled, the total size in
ManagedLedgerImplis inaccurate. Because when the total size is updated inOpAddEntry#safeRun, thedataLengthis the initial size ofdatawhenOpAddEntryis constructed, butdatacould be changed viasetDatamethod.The inaccurate total size could affect the retention size validation. Because in
ManagedLedgerImpl#internalTrimLedgers, the total size reduces by the size ofLedgerInfo, which is assigned from theLedgerHandle#getLength(). Therefore, the total size will become 0 or less before all ledgers are removed.Modifications
dataLengthfield insetDatamethod.testManagedLedgerTotalSizetest toBrokerEntryMetadataE2ETest. It produces 10 messages and trigger the rollover manually so that the firstLedgerInfoof the managed ledger contains the correct total bytes. Then compare thetotalSizefield with it to verify this fix works.Verifying this change
This change added test
BrokerEntryMetadataE2ETest#testManagedLedgerTotalSize.