Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove catching NamingException. #12725

Merged
merged 2 commits into from Nov 11, 2021
Merged

Remove catching NamingException. #12725

merged 2 commits into from Nov 11, 2021

Conversation

Technoboy-
Copy link
Contributor

Motivation

In #12590, we wrap NamingException into CompletableFuture in AbstractReplicator#validatePartitionedTopicAsync.

So in BrokerService#createNonPersistentTopic, it will never throw NamingException.

Modifications

  • Remove catching NamingException.

Documentation

  • [ x ] no-need-doc

@Technoboy- Technoboy- self-assigned this Nov 10, 2021
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 10, 2021
@codelipenghui codelipenghui added this to the 2.10.0 milestone Nov 10, 2021
RobertIndie
RobertIndie reviewed Nov 11, 2021
View reviewed changes
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the NamingException thrown in the constructor of the SystemTopic and PersistentTopic.

@Technoboy-
Copy link
Contributor Author

I think we can remove the NamingException thrown in the constructor of the SystemTopic and PersistentTopic.

Yes, right. thanks.

@codelipenghui codelipenghui merged commit 6ab7401 into apache:master Nov 11, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@Technoboy- @eolivelli
Remove catching NamingException. (apache#12725)
85580f2
codelipenghui pushed a commit that referenced this pull request Dec 20, 2021
@Technoboy- @codelipenghui
Remove catching NamingException. (#12725)
d7ae988 
(cherry picked from commit 6ab7401)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 20, 2021
@Technoboy- Technoboy- deleted the remove-naming-exception branch August 10, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertIndie RobertIndie RobertIndie approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@Technoboy- Technoboy-

Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Technoboy- @codelipenghui @RobertIndie @eolivelli @gaoran10