Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove catching NamingException. #12725

Merged
merged 2 commits into from Nov 11, 2021
Merged

Remove catching NamingException. #12725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9001d23
Remove NamingException.
Technoboy- Nov 10, 2021
65fc1fd
Remove throws NamingException.
Technoboy- Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
View file
Open in desktop
Expand Up @@ -1353,7 +1353,7 @@ public void openLedgerComplete(ManagedLedger ledger, Object ctx) {

return null;
});
} catch (NamingException | PulsarServerException e) {
} catch (PulsarServerException e) {
log.warn("Failed to create topic {}-{}", topic, e.getMessage());
pulsar.getExecutor().execute(() -> topics.remove(topic, topicFuture));
topicFuture.completeExceptionally(e);
Expand Down
2 changes: 1 addition & 1 deletion pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
View file
Open in desktop
Expand Up @@ -250,7 +250,7 @@ public void reset() {
}
}

public PersistentTopic(String topic, ManagedLedger ledger, BrokerService brokerService) throws NamingException {
public PersistentTopic(String topic, ManagedLedger ledger, BrokerService brokerService) {
super(topic, brokerService);
this.ledger = ledger;
this.subscriptions = new ConcurrentOpenHashMap<>(16, 1);
Expand Down
4 changes: 1 addition & 3 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SystemTopic.java
View file
Open in desktop
Expand Up @@ -23,12 +23,10 @@
import org.apache.bookkeeper.mledger.ManagedLedger;
import org.apache.pulsar.broker.PulsarServerException;
import org.apache.pulsar.broker.service.BrokerService;
import org.apache.pulsar.broker.service.BrokerServiceException;

public class SystemTopic extends PersistentTopic {

public SystemTopic(String topic, ManagedLedger ledger, BrokerService brokerService)
throws BrokerServiceException.NamingException, PulsarServerException {
public SystemTopic(String topic, ManagedLedger ledger, BrokerService brokerService) throws PulsarServerException {
super(topic, ledger, brokerService);
}

Expand Down