Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clean up] Delete unused imports #12791

Merged
merged 1 commit into from
Nov 14, 2021
Merged

[clean up] Delete unused imports #12791

merged 1 commit into from
Nov 14, 2021

Conversation

shoothzj
Copy link
Member

Modifications

related to #12690 , @gaozhangmin doesn't clean up the unused import in tests.

Documentation

  • no-need-doc
    just clean up

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 14, 2021
@BewareMyPower
Copy link
Contributor

I found #8878 has already adds the checkstyle plugin for pulsar-broker module, do you know why it didn't check the unused imports? Or could we add an automatic check for it?

@merlimat merlimat added this to the 2.10.0 milestone Nov 14, 2021
@merlimat merlimat added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Nov 14, 2021
@merlimat merlimat merged commit d8260d4 into apache:master Nov 14, 2021
@shoothzj shoothzj deleted the delete-unused-import branch November 14, 2021 22:46
@shoothzj
Copy link
Member Author

I found #8878 has already adds the checkstyle plugin for pulsar-broker module, do you know why it didn't check the unused imports? Or could we add an automatic check for it?

It's works, but only new modified file. test in #12799

eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
@shoothzj @eolivelli
[clean up] Delete unused imports (apache#12791)
a373965
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
@shoothzj
[clean up] Delete unused imports (apache#12791)
bbd0542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@shoothzj shoothzj

Labels
doc-not-needed Your PR changes do not impact docs type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shoothzj @BewareMyPower @merlimat