Remove readerCaches and close reader when exception occurs in SystemTopicBasedTopicPoliciesService #12873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opicBasedTopicPoliciesService.
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
Technoboy-
added
doc-not-needed
codelipenghui
approved these changes
Nov 18, 2021
dlg99
pushed a commit
to dlg99/pulsar
that referenced
this pull request
Nov 23, 2021
…opicBasedTopicPoliciesService. (apache#12873)
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
…opicBasedTopicPoliciesService. (apache#12873)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…opicBasedTopicPoliciesService. (apache#12873)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is related to #12773. As @codelipenghui has commented to remove the readerCaches and close reader.
But due to some reasons, that pr forget to do that.
Documentation
no-need-doc