[Broker] Change create topic return error to Status.BAD_REQUEST #12919
Conversation
|
@congbobo184:Thanks for your contribution. For this PR, do we need to update docs? |
congbobo184
added
doc-not-needed
|
@congbobo184:Thanks for providing doc info! |
codelipenghui
added
release/2.9.1
and removed
cherry-picked/branch-2.9
| @@ -250,7 +250,7 @@ protected void validateAdminAndClientPermission() { | |||
| protected void validateCreateTopic(TopicName topicName) { | |||
| if (isTransactionInternalName(topicName)) { | |||
There was a problem hiding this comment.
The topic TRANSACTION_COORDINATOR_ASSIGN could be created by users, right?
| @@ -250,7 +250,7 @@ protected void validateAdminAndClientPermission() { | |||
| protected void validateCreateTopic(TopicName topicName) { | |||
| if (isTransactionInternalName(topicName)) { | |||
| log.warn("Try to create a topic in the system topic format! {}", topicName); | |||
| throw new RestException(Status.CONFLICT, "Cannot create topic in system topic format!"); | |||
| throw new RestException(Status.BAD_REQUEST, "Cannot create topic in system topic format!"); | |||
There was a problem hiding this comment.
Could we list the system topics here? Users could know which are system topics.
| if (e.getCause() instanceof NotAllowedException) { | ||
| throw new RestException(Status.CONFLICT, e.getCause()); | ||
| throw new RestException(Status.BAD_REQUEST, e.getCause()); |
There was a problem hiding this comment.
Interesting, do we through NotAllowedException for pulsar().getBrokerService().getTopicIfExists()? @congbobo184 Could you please help check how to improve this part? From the method name, we only get the topic ref if the topic exists, but looks like it also create topics.
| @@ -250,7 +250,7 @@ protected void validateAdminAndClientPermission() { | |||
| protected void validateCreateTopic(TopicName topicName) { | |||
| if (isTransactionInternalName(topicName)) { | |||
| log.warn("Try to create a topic in the system topic format! {}", topicName); | |||
There was a problem hiding this comment.
change the log.warn information to log.warn("Forbidden to create transaction internal topic: {}" topicName) maybe more clear.
| if (e.getCause() instanceof NotAllowedException) { | ||
| throw new RestException(Status.CONFLICT, e.getCause()); | ||
| throw new RestException(Status.BAD_REQUEST, e.getCause()); |
|
@congbobo184 Could you please check the comments? |
…c_error_code_change
…c_error_code_change
…c_error_code_change
…c_error_code_change
(cherry picked from commit 2262a5d)
congbobo184
deleted the
congbobo184_create_transaction_system_topic_error_code_change
branch
Motivation
When create transaction system topic, broker will return Status.CONFLICT, It does not conform to the wrong return semantics of the method. So change it to Status.BAD_REQUEST, when client receive Status.BAD_REQUEST, it will generic PulsarAdminException and error code is Status.BAD_REQUEST
Modifications
change the error code to Status.BAD_REQUEST when create transaction system topic.
Verifying this change
change test verify