-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Authorization] Revert new AuthorizationProvider method #13133
[Authorization] Revert new AuthorizationProvider method #13133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. LGTM
/pulsarbot run-failure-checks |
/pulsarbot run-failure-checks |
1 similar comment
/pulsarbot run-failure-checks |
I think the 2.9.0 already contains #12600? do you need to also revert the 2.9.0 release? |
@codelipenghui - you're right, it was included in the 2.9.0 release. I thought it had missed the release because it has the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@michaeljmarshall I think it's ok to remove it in 2.9.1 since we will not introduce breaking changes to 2.9.1, just a user implemented method will not be used. So we only have a breaking change in 2.9.0. /cc @merlimat Please help check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
(cherry picked from commit d1156ca)
(cherry picked from commit d1156ca)
Motivation
In PR #12600, we added a method to the
AuthorizationProvider
that is not used outside of implementations of theAuthorizationProvider
itself. Since this interface is public, we should make sure that all methods are necessary. Further, since we cherry picked the commit for #12600 tobranch-2.9
andbranch-2.8
, we introduced a potentially breaking change for third party implementations of theAuthorizationProvider
interface. While the commit itself isn't breaking, it does imply that the interface has a method that could be used by the authorization service or some other part of Pulsar. Since third party implementations might not have this method implemented, they could break if we started to use the method. Since #12600 includes an important bug fix, we should not couple an expansion of the API with a bug fix.For added context, it is likely that this method was added because there are other similar methods in the interface. For example, the interface has the following methods:
allowSinkOpsAsync
,allowSourceOpsAsync
, andallowFunctionOpsAsync
. These methods are much older and are called by theAuthenticationService
.Note: this was only released in 2.9.0. It hasn't been in any other releases yet.
Note: the new method has not yet been published in any releases. It is set to go in 2.8.2 and 2.9.1.Modifications
AuthorizationProvider#allowConsumeOpsAsync
method from the interface and from all implementations of the interface.Verifying this change
This is a trivial change. No underlying logic is changed by this commit.
Does this pull request potentially affect one of the following parts:
This fix addresses a potentially breaking change.
Documentation
no-need-doc