[#12423] allow GetTopicsOfNamespace op with consume permission
#12600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
|
@freeznet:Thanks for providing doc info! |
|
@freeznet:Thanks for providing doc info! |
codelipenghui
approved these changes
Nov 4, 2021
hangc0276
approved these changes
Nov 5, 2021
eolivelli
pushed a commit
that referenced
this pull request
Nov 9, 2021
Fixes #12423 ### Motivation Regex subscription requires to get the topics list of given namespace with GetTopicsOfNamespace request, but this request requires tenant admin permission which will block the regex consumers who only have consume permission. ### Modifications This PR added the consume permission check for GetTopicsOfNamespace, which allows consumers get the topics list with consume permission. (cherry picked from commit 7e078aa)
codelipenghui
pushed a commit
that referenced
this pull request
Nov 18, 2021
Fixes #12423 ### Motivation Regex subscription requires to get the topics list of given namespace with GetTopicsOfNamespace request, but this request requires tenant admin permission which will block the regex consumers who only have consume permission. ### Modifications This PR added the consume permission check for GetTopicsOfNamespace, which allows consumers get the topics list with consume permission. (cherry picked from commit 7e078aa)
codelipenghui
added
release/2.8.2
cherry-picked/branch-2.8
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Nov 29, 2021
Fixes apache#12423 ### Motivation Regex subscription requires to get the topics list of given namespace with GetTopicsOfNamespace request, but this request requires tenant admin permission which will block the regex consumers who only have consume permission. ### Modifications This PR added the consume permission check for GetTopicsOfNamespace, which allows consumers get the topics list with consume permission.
1 task
|
Updated the label, as this commit is included in the 2.9.0 release. See #13133 for more information. |
This was referenced Feb 28, 2022
BewareMyPower
pushed a commit
to streamnative/kop
that referenced
this pull request
Feb 28, 2022
The apache/pulsar#12600 changed behavior. Before this change, only tenant admin allow to list topics, after apache/pulsar#12600, it allows consume permission list topics.
BewareMyPower
pushed a commit
to streamnative/kop
that referenced
this pull request
Feb 28, 2022
The apache/pulsar#12600 changed behavior. Before this change, only tenant admin allow to list topics, after apache/pulsar#12600, it allows consume permission list topics.
|
It seems that this patch is not present in v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12423
Motivation
Regex subscription requires to get the topics list of given namespace with
GetTopicsOfNamespacerequest, but this request requires tenant admin permission which will block the regex consumers who only haveconsumepermission.Modifications
This PR added the
consumepermission check forGetTopicsOfNamespace, which allows consumers get the topics list withconsumepermission.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)