Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-45: Allow to start bookie with Pulsar metadata store backend #13296

Merged
merged 8 commits into from
Jan 16, 2022

Conversation

merlimat
Copy link
Contributor

Motivation

We need to add system properties (bookkeeper.metadata.{bookie,client}.drivers)for the Bookie and BookieShell commands to discover the BK bridge to the Pulsar metadata provider.

This is what will allow to configure bk metadataUri such as metadata-store:zk:my-zk1:2181 or metadata-store:etcd:http://my-etcd:2379.

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Dec 14, 2021
@merlimat merlimat added this to the 2.10.0 milestone Dec 14, 2021
@merlimat merlimat self-assigned this Dec 14, 2021
@shoothzj
Copy link
Member

@merlimat Could you pull the master code, in case there are any check-style violations

@github-actions
Copy link

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@Anonymitaet
Copy link
Member

Anonymitaet commented Dec 15, 2021

@merlimat since this is a new feature, so we need to update docs? can you label this PR? thanks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@merlimat merlimat merged commit ad57f35 into apache:master Jan 16, 2022
@merlimat merlimat deleted the configure-metadata-store branch January 16, 2022 06:35
MMirelli added a commit to MMirelli/pulsar that referenced this pull request Jan 21, 2022
RobertIndie added a commit to RobertIndie/pulsar that referenced this pull request Jan 24, 2022
Motivation
* Add doc for apache#13889 and apache#13296

Modification
* Update doc for `metadataStoreUrl` and `configurationMetadataStoreUrl` in `pulsar initialize-cluster-metadata`

Signed-off-by: Zike Yang <zkyang@streamnative.io>
codelipenghui pushed a commit that referenced this pull request Jan 24, 2022
Motivation
* Add doc for #13889 and #13296

Modification
* Update doc for `metadataStoreUrl` and `configurationMetadataStoreUrl` in `pulsar initialize-cluster-metadata`

Signed-off-by: Zike Yang <zkyang@streamnative.io>
@Anonymitaet
Copy link
Member

Hi @momo-jun has doc been updated for this PR? Thanks

@momo-jun
Copy link
Contributor

Hi @momo-jun has doc been updated for this PR? Thanks

Yes, @RobertIndie added docs for this PR through #13921.

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-label-missing labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added. type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants