Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Allow configuring configurationMetadataStore when initialize cluster metadata #13889

Merged
merged 1 commit into from
Jan 22, 2022
Merged

[Broker] Allow configuring configurationMetadataStore when initialize cluster metadata #13889

merged 1 commit into from
Jan 22, 2022

Conversation

RobertIndie
Copy link
Member

Master Issue: #13760

Motivation

As per #13077, configurationStoreServers need to be renamed to configurationMetadataStoreUrl.

Modifications

  • Add configurationMetadataStore to PulsarClusterMetadataSetup.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-required

@RobertIndie
[Broker] Allow configuring configurationMetadataStore when initialize…
25ceec8 
… cluster metadata

Motivation
As per apache#13077, `configurationStoreServers` need to be renamed to `configurationMetadataStoreUrl`.

Modification
* Add `configurationMetadataStore` to PulsarClusterMetadataSetup.

Signed-off-by: Zike Yang <zkyang@streamnative.io>
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jan 21, 2022
@merlimat merlimat merged commit 9dbee16 into apache:master Jan 22, 2022
RobertIndie added a commit to RobertIndie/pulsar that referenced this pull request Jan 24, 2022
@RobertIndie
[Doc] Update doc for pulsar initialize-cluster-metadata
77b4721 
Motivation
* Add doc for apache#13889 and apache#13296

Modification
* Update doc for `metadataStoreUrl` and `configurationMetadataStoreUrl` in `pulsar initialize-cluster-metadata`

Signed-off-by: Zike Yang <zkyang@streamnative.io>
@RobertIndie RobertIndie mentioned this pull request Jan 24, 2022
Merged
1 task
codelipenghui pushed a commit that referenced this pull request Jan 24, 2022
@RobertIndie
[Doc] Update doc for pulsar initialize-cluster-metadata (#13921)
0fad6a8 
Motivation
* Add doc for #13889 and #13296

Modification
* Update doc for `metadataStoreUrl` and `configurationMetadataStoreUrl` in `pulsar initialize-cluster-metadata`

Signed-off-by: Zike Yang <zkyang@streamnative.io>
@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@RobertIndie RobertIndie

Labels
doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RobertIndie @merlimat @gaozhangmin @codelipenghui @mattisonchao @Anonymitaet