Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 12726] [broker] Fix deadlock in metadata-store callback thread for branch 2.9 #13426

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

Jason918
Copy link
Contributor

@Jason918 Jason918 commented Dec 21, 2021

Fixes #12726 for branch 2.9

Motivation

See #12726

#12753 fixed this in master, but can not merged into branch 2.9.

Modifications

Use thenAcceptAsync instead to avoid dead lock on metadata thread.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as org.apache.pulsar.broker.admin.PersistentTopicsTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc
    Bug fix.

@Jason918
Copy link
Contributor Author

@codelipenghui PTAL

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Dec 21, 2021
@codelipenghui codelipenghui merged commit c5a4639 into apache:branch-2.9 Dec 21, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants