Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Fix call sync method in async rest api for internalExpireMessagesByPosition #13878

Merged
merged 5 commits into from
Jan 27, 2022
Merged

[Broker] Fix call sync method in async rest api for internalExpireMessagesByPosition #13878

merged 5 commits into from
Jan 27, 2022

Conversation

liudezhi2098
Copy link
Contributor

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalExpireMessagesByPosition.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 21, 2022
@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@mattisonchao mattisonchao mentioned this pull request Jan 21, 2022
Closed
26 tasks
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@mattisonchao
Copy link
Member

emmm. i think we need to refactor this code. it seems very like callback hell.

@liudezhi2098
Do you have any good idea ?

@liudezhi2098
Copy link
Contributor Author

emmm. i think we need to refactor this code. it seems very like callback hell.

@liudezhi2098 Do you have any good idea ?
The code is not very nice，adjust the style。

@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

Technoboy-
Technoboy- approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 merged commit 61f99cb into apache:master Jan 27, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@liudezhi2098
[Broker] Fix call sync method in async rest api for internalExpireMes…
6525e60 
…sagesByPosition (apache#13878)

### Motivation
Avoid call sync method in async rest API for PersistentTopicsBase#internalExpireMessagesByPosition.

### Modifications
Use async instead of sync method.
@Technoboy- Technoboy- mentioned this pull request Apr 22, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@liudezhi2098 liudezhi2098

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liudezhi2098 @mattisonchao @hangc0276 @Technoboy- @codelipenghui