Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] PersistentTopicsBase has many async method call sync method. #13854

Closed
26 tasks done
mattisonchao opened this issue Jan 20, 2022 · 16 comments
Closed
26 tasks done

[Broker] PersistentTopicsBase has many async method call sync method. #13854

mattisonchao opened this issue Jan 20, 2022 · 16 comments
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@mattisonchao
Copy link
Member

mattisonchao commented Jan 20, 2022 •
edited
Loading

Motivation

This issue was created to track the process of fixing serial async method calls sync method in PersistentTopicsBase.

Progress
@mattisonchao mattisonchao added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jan 20, 2022
@mattisonchao mattisonchao changed the title [Broker] PersistentTopicsBase has many async method call sync method. [Broker] PersistentTopicsBase has many async method call sync method. Jan 20, 2022
@sijie sijie mentioned this issue Jan 20, 2022
Closed
23 tasks
@mattisonchao mattisonchao mentioned this issue Jan 21, 2022
Merged
2 tasks
@gaozhangmin
Copy link
Contributor

Can I try to help with this?

@codelipenghui
Copy link
Contributor

@mattisonchao Great job!

@gaozhangmin gaozhangmin mentioned this issue Jan 21, 2022
Merged
3 tasks
@mattisonchao
Copy link
Member Author

Can I try to help with this?

Sure ! Which one do you like ?

@gaozhangmin
Copy link
Contributor

gaozhangmin commented Jan 21, 2022 •
edited
Loading

  • internalGetLastMessageId

I did internalGetLastMessageId. the rest not completed yet, Please assign some to me. @mattisonchao

@Jason918
Copy link
Contributor

I did internalGetLastMessageId. the rest not completed yet, Please assign some to me. @mattisonchao

You can continue to do internalGetLastMessageId.

@Jason918 Jason918 mentioned this issue Jan 21, 2022
Merged
2 tasks
@gaozhangmin gaozhangmin mentioned this issue Jan 21, 2022
Merged
3 tasks
@gaozhangmin
Copy link
Contributor

internalGetPartitionedStats done.

This was referenced Jan 21, 2022
Merged
Merged
@gaozhangmin gaozhangmin mentioned this issue Jan 22, 2022
Closed
3 tasks
@AnonHxy AnonHxy mentioned this issue Jan 22, 2022
Merged
2 tasks
@HQebupt HQebupt mentioned this issue Jan 22, 2022
Closed
1 task
@AnonHxy AnonHxy mentioned this issue Jan 23, 2022
Closed
2 tasks
@codertmy codertmy mentioned this issue Jan 24, 2022
Merged
2 tasks
@liudezhi2098
Copy link
Contributor

internalTerminatePartitionedTopic done

codelipenghui pushed a commit that referenced this issue Jan 26, 2022
@gaozhangmin
[Issue 13854][broker] Fix call sync method in async rest api for inte…
67caae7 
…rnalGetPartitionedStats (#13886)

Master Issue: #13854

### Motivation


Avoid call sync method in async rest API for PersistentTopicsBase#internalGetPartitionedStats.
@liudezhi2098
Copy link
Contributor

@mattisonchao need fix
internalSetReplicationClusters
internalSetBacklogQuota
internalRemoveReplicationClusters
preValidation

@liudezhi2098
Copy link
Contributor

And NamespacesBase also has async method call sync method.

@mattisonchao
Copy link
Member Author

And NamespacesBase also has async method call sync method.

Yes, I will track it at another issue.

@mattisonchao
Copy link
Member Author

mattisonchao commented Jan 26, 2022 •
edited
Loading

internalSetReplicationClusters
internalSetBacklogQuota
internalRemoveReplicationClusters
preValidation

@liudezhi2098 Good catch!
Would you like to fix it ?

@liudezhi2098
Copy link
Contributor

internalSetReplicationClusters
internalSetBacklogQuota
internalRemoveReplicationClusters
preValidation

@liudezhi2098 Good catch! Would you like to fix it ?

internalSetReplicationClusters、internalRemoveReplicationClusters

@liudezhi2098 liudezhi2098 mentioned this issue Jan 26, 2022
Merged
1 task
@Technoboy-
Copy link
Contributor

preValidation

@RobertIndie
Copy link
Member

I want to fix internalSetBacklogQuota .

This was referenced Jan 28, 2022
Merged
Merged
Merged
Closed
RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
@RobertIndie
[Broker] Make PersistentTopicsBase#internalSetBacklogQuota async
224a2bf 
Motivation
See apache#13854

Modification
* Make PersistentTopicsBase#internalSetBacklogQuota async.
* Change getRetentionPolicies to getRetentionPoliciesAsync

Signed-off-by: Zike Yang <zkyang@streamnative.io>
@RobertIndie RobertIndie mentioned this issue Jan 30, 2022
Merged
1 task
@liudezhi2098
Copy link
Contributor

internalSetReplicationClusters、internalRemoveReplicationClusters done

@nodece
Copy link
Member

nodece commented Jan 30, 2022

I summited #13841 to fix reset cursor, this PR needs review.

@Technoboy- Technoboy- mentioned this issue Feb 23, 2022
Closed
@sijie sijie mentioned this issue Mar 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Jason918 @Technoboy- @gaozhangmin @codelipenghui @nodece @RobertIndie @liudezhi2098 @mattisonchao