[Issue 13854][broker] Fix call sync method in async rest api for internalGetPartitionedStats #13886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jan 21, 2022
|
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs? |
Jason918
approved these changes
Jan 21, 2022
|
/pulsarbot run-failure-checks |
liudezhi2098
approved these changes
Jan 22, 2022
Jason918
requested changes
Jan 22, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
26 tasks
|
/pulsarbot run-failure-checks |
3 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
shoothzj
approved these changes
Jan 24, 2022
|
Hi @gaozhangmin do we need to update docs for this PR? |
|
@gaozhangmin:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
Jason918
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13854
Motivation
Avoid call sync method in async rest API for PersistentTopicsBase#internalGetPartitionedStats.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)