Add pulsar_subscription_consumers_count metric #15042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative PR to #15041 for discussion. |
Technoboy-
approved these changes
Apr 6, 2022
|
Had to do a fix for when consumer metrics are not enabled. Can you review again ? |
Closed
3 tasks
eolivelli
approved these changes
Apr 6, 2022
codelipenghui
approved these changes
Apr 19, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Fixes apache#15032 ### Modifications Added metric `pulsar_subscription_consumers_count`
Anonymitaet
added
doc-required
|
ping @momo-jun for providing help on docs |
|
Hi @cbornet, will you like to submit a follow-up PR to add docs? Let us know your plan or any other assistance you need. |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
Fixes apache#15032 ### Modifications Added metric `pulsar_subscription_consumers_count` (cherry picked from commit 789fa50)
Doc status update@cbornet will submit a PR to add docs soon. |
4 tasks
Anonymitaet
added
doc-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15032
Modifications
Added metric
pulsar_subscription_consumers_countVerifying this change
This change added tests and can be verified as follows:
Run
PrometheusMetricsTest::testNonPersistentSubMetricsDoes this pull request potentially affect one of the following parts:
no
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docThere are other undocumented subscription metrics. Should document all of them in another PR ?
doc(If this PR contains doc changes)