Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broker][monitor] add persistent_subscription_consumer_count for PersistentSubscription #15041

Closed
wants to merge 2 commits into from

Conversation

tjiuming
Copy link
Contributor

@tjiuming tjiuming commented Apr 6, 2022

Fixes #15032

Motivation

add persistent_subscription_consumer_count for PersistentSubscription

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Apr 6, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using the Prometheus API ?

Please follow the usual pattern.
If we want to switch to Pure Prometheus API we should discuss this in the community and make a plan

@tjiuming
Copy link
Contributor Author

tjiuming commented Apr 6, 2022

Why are we using the Prometheus API ?

Please follow the usual pattern. If we want to switch to Pure Prometheus API we should discuss this in the community and make a plan

There are already so many Prometheus API usages in pulsar, right? Do we need to delete all the usages and discuss if we are allowed to use Prometheus API?

@eolivelli
Copy link
Contributor

eolivelli commented Apr 6, 2022

In this case the subscription metrics are handled in another way, let's stick to the pattern, like in #15042

https://github.com/apache/pulsar/pull/15042/files#diff-79bde2a6feed80b6b6b4b6950bc7d4ccd93946a8ec0b40cc1bef2e7b3e498f21R271

@tjiuming
Copy link
Contributor Author

tjiuming commented Apr 6, 2022

In this case the subscription metrics are handled in another way, let's stick to the pattern, like in #15042

https://github.com/apache/pulsar/pull/15042/files#diff-79bde2a6feed80b6b6b4b6950bc7d4ccd93946a8ec0b40cc1bef2e7b3e498f21R271

I’m confused, how could I know which metrics can be handled by Prometheus and which can't.

@Anonymitaet
Copy link
Member

@momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks

@codelipenghui
Copy link
Contributor

@tjiuming I'm going to close this PR first since #15042 has merged

@Anonymitaet Anonymitaet removed the doc-required Your PR changes impact docs and you will update later. label May 5, 2022
@tjiuming tjiuming deleted the dev/sub_consumer_count branch August 14, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants