[cleanup][broker]Tidy dispatchRateLimiter init #15604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
tidy_init_dispatch_rate_limiter
branch
from
7758c15
to
fc30f4b
Compare
|
/pulsarbot run-failure-checks |
4 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
AnonHxy
force-pushed
the
tidy_init_dispatch_rate_limiter
branch
from
fc30f4b
to
3502cc7
Compare
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
May 18, 2022
codelipenghui
added
type/cleanup
codelipenghui
changed the title
Technoboy-
reviewed
May 18, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
Technoboy-
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tidy up the code updating rate limiter to make it more clear.
Modifications
updateSubscribeRateLimiter()out ofinitializeRateLimiterIfNeededto make the code more clear.Verifying this change.
initializeRateLimiterIfNeededtoinitializeDispatchRateLimiterIfNeededDocumentation
no-need-doc