Replicator-producer creation should be idempotent #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
rdhabalia
force-pushed
the
dup_repl_same
branch
from
ee7d651
to
72a610f
Compare
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
hrsakai
pushed a commit
to hrsakai/pulsar
that referenced
this pull request
Dec 10, 2020
* Fixed the connection pool logic * Fixed mocked object for tests * Fixed indentation
cbornet
pushed a commit
to cbornet/pulsar
that referenced
this pull request
Feb 22, 2023
…erService (apache#19153) (apache#161) * [improve] PIP-241: add TopicEventListener / topic events for the BrokerService (apache#19153) (cherry picked from commit 3e44d1e) --------- Co-authored-by: Andrey Yegorov <andrey.yegorov@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replicator-producer creation should be idempotent and
PersistentTopicstarts a new Replicator on every invocation. which creates dangling replicator in a system.Modifications
Create a topic-replicator for a given remote cluster only once.
Result
It prevents to create multiple duplicate replicator.