[improve][connector] Add getSourceConfig method on SourceContext. #16305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@nlu90 @freeznet @codelipenghui Please help review it, thanks. |
Do you mean add it to |
Yes. |
freeznet
approved these changes
Jul 10, 2022
codelipenghui
added
type/enhancement
codelipenghui
approved these changes
Jul 13, 2022
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Jul 14, 2022
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
^^ The PR is good, but the description has some typo. change |
Sorry, I changed. |
zymap
added a commit
to zymap/pulsar-io-lakehouse
that referenced
this pull request
Sep 15, 2022
--- *Motivation* Pulsar has added the new method into the SourceContext and SinkContext. Which will break the current code with the implementation. Adding the related implementation to avoid building failed. apache/pulsar#15482 apache/pulsar#16305 *Modification* - Adding the realted implementation to the class
hangc0276
pushed a commit
to streamnative/pulsar-io-lakehouse
that referenced
this pull request
Sep 15, 2022
--- *Motivation* Pulsar has added the new method into the SourceContext and SinkContext. Which will break the current code with the implementation. Adding the related implementation to avoid building failed. apache/pulsar#15482 apache/pulsar#16305 *Modification* - Adding the realted implementation to the class
zymap
added a commit
to streamnative/pulsar-io-lakehouse
that referenced
this pull request
Sep 15, 2022
--- *Motivation* Pulsar has added the new method into the SourceContext and SinkContext. Which will break the current code with the implementation. Adding the related implementation to avoid building failed. apache/pulsar#15482 apache/pulsar#16305 *Modification* - Adding the realted implementation to the class (cherry picked from commit c62df08)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The configuration of SourceConfig is rich, and the user can flexibly specify it when registering the source. But some sources do not support these configurations. For example, some sources do not support
EFFECTIVELY_ONCEguarantees, because the upstream system cannot generate ordered sequence id.So, add the
getSourceConfigmethod to SourceContext, enables the source to validate the configuration when executing thesource.openmethod.Modifications
Documentation
doc-not-needed