[improve][java-client] Support passing existing scheduled executor providers to the client #16334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oviders to the client ### Motivation apache#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like apache#12037.
coderzc
approved these changes
Jul 1, 2022
merlimat
reviewed
Jul 1, 2022
| @@ -196,8 +197,8 @@ private PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopG | |||
| new ExecutorProvider(conf.getNumListenerThreads(), "pulsar-external-listener"); | |||
| this.internalExecutorProvider = internalExecutorProvider != null ? internalExecutorProvider : | |||
| new ExecutorProvider(conf.getNumIoThreads(), "pulsar-client-internal"); | |||
| this.scheduledExecutorProvider = new ScheduledExecutorProvider(conf.getNumIoThreads(), | |||
| "pulsar-client-scheduled"); | |||
| this.scheduledExecutorProvider = scheduledExecutorProvider != null ? scheduledExecutorProvider : | |||
There was a problem hiding this comment.
Shouldn’t we consider whether it was passed in or created internally, at the moment of closing it?
There was a problem hiding this comment.
@merlimat Fixed.
merlimat
approved these changes
Jul 1, 2022
codelipenghui
added a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jul 2, 2022
### Motivation apache#16334 supports passing scheduled executor to the client. Use a shared scheduled executor for the broker clients which used by replicator and system topics.
4 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Jul 5, 2022
…oviders to the client (apache#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation apache#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like apache#12037. * Apply comment.
michaeljmarshall
approved these changes
Jul 5, 2022
codelipenghui
added a commit
that referenced
this pull request
Jul 10, 2022
…oviders to the client (#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation #16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like #12037. * Apply comment. (cherry picked from commit f159f62)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 11, 2022
…oviders to the client (apache#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation apache#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like apache#12037. * Apply comment. (cherry picked from commit f159f62) (cherry picked from commit 4562d25)
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
…oviders to the client (apache#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation apache#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like apache#12037. * Apply comment.
2 tasks
congbobo184
pushed a commit
that referenced
this pull request
Nov 10, 2022
…oviders to the client (#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation #16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like #12037. * Apply comment. (cherry picked from commit f159f62)
congbobo184
pushed a commit
that referenced
this pull request
Dec 1, 2022
…oviders to the client (#16334) * [improve][java-client] Support passing existing scheduled executor providers to the client ### Motivation #16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like #12037. * Apply comment. (cherry picked from commit f159f62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#16236 introduced a new scheduled executor but does not support passing the existing scheduled executor providers like #12037.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)