Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][connector] ElasticSearch Sink: add an option to copy key fields into the value #17117

Merged
merged 3 commits into from Sep 1, 2022

Conversation

nicoloboschi
Copy link
Contributor

Motivation

Add the ability to add the key fields to the document. With this option the resulting document will contain both key and value fields if schema is enabled and the message is JSON/Avro format.

Modifications

  • New option copyKeyFields default to false. If true, the key fields will be copied to the document.

In order to be activated it's required to:

  • set copyKeyFields to true

  • set schemaEnable to true

  • the message format be in JSON or AVRO

  • message value is not null

  • doc

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 17, 2022
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoloboschi nicoloboschi merged commit 5647109 into apache:master Sep 1, 2022
@nicoloboschi nicoloboschi added this to the 2.12.0 milestone Sep 1, 2022
nodece pushed a commit to nodece/pulsar that referenced this pull request Sep 8, 2022
@momo-jun momo-jun changed the title [feat][connector] ElasticSearch Sink: add a option to copy key fields into the value [feat][connector] ElasticSearch Sink: add an option to copy key fields into the value Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants