[fix][cli] Fix mbeans to json #17676

nodece · 2022-09-15T15:12:52Z

Motivation

Fix the mbeans to JSON.

Broker log:

	org.glassfish.jersey.server.internal.process.MappableException: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Invalid type definition for type `com.sun.management.internal.GcInfoCompositeData`: Failed to construct BeanSerializer for [simple type, class com.sun.management.internal.GcInfoCompositeData]: (java.lang.IllegalArgumentException) Failed to call `setAccess()` on Method 'getGcInfo' (of class `com.sun.management.internal.GcInfoCompositeData`) due to `java.lang.reflect.InaccessibleObjectException`, problem: Unable to make public com.sun.management.GcInfo com.sun.management.internal.GcInfoCompositeData.getGcInfo() accessible: module jdk.management does not "exports com.sun.management.internal" to unnamed module @5bc79255 (through reference chain: java.util.ArrayList[26]->org.apache.pulsar.common.stats.Metrics["metrics"])
	at org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116)
	at org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:635)
	at org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:373)
	at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:363)
	at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:258)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:265)
	at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:234)
	at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:680)
	at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394)
	at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:366)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:319)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
	at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)
	at org.apache.pulsar.broker.web.ResponseHandlerFilter.doFilter(ResponseHandlerFilter.java:67)
	at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
	at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
	at org.eclipse.jetty.servlets.QoSFilter.doFilter(QoSFilter.java:202)
	at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
	at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:234)
	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
	at org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:181)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.Server.handle(Server.java:516)
	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
	at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Invalid type definition for type `com.sun.management.internal.GcInfoCompositeData`: Failed to construct BeanSerializer for [simple type, class com.sun.management.internal.GcInfoCompositeData]: (java.lang.IllegalArgumentException) Failed to call `setAccess()` on Method 'getGcInfo' (of class `com.sun.management.internal.GcInfoCompositeData`) due to `java.lang.reflect.InaccessibleObjectException`, problem: Unable to make public com.sun.management.GcInfo com.sun.management.internal.GcInfoCompositeData.getGcInfo() accessible: module jdk.management does not "exports com.sun.management.internal" to unnamed module @5bc79255 (through reference chain: java.util.ArrayList[26]->org.apache.pulsar.common.stats.Metrics["metrics"])
	at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:72)
	at com.fasterxml.jackson.databind.SerializerProvider.reportBadTypeDefinition(SerializerProvider.java:1272)
	at com.fasterxml.jackson.databind.ser.BeanSerializerFactory.constructBeanOrAddOnSerializer(BeanSerializerFactory.java:474)
	at com.fasterxml.jackson.databind.ser.BeanSerializerFactory.findBeanOrAddOnSerializer(BeanSerializerFactory.java:294)
	at com.fasterxml.jackson.databind.ser.BeanSerializerFactory._createSerializer2(BeanSerializerFactory.java:239)
	at com.fasterxml.jackson.databind.ser.BeanSerializerFactory.createSerializer(BeanSerializerFactory.java:173)
	at com.fasterxml.jackson.databind.SerializerProvider._createUntypedSerializer(SerializerProvider.java:1495)
	at com.fasterxml.jackson.databind.SerializerProvider._createAndCacheUntypedSerializer(SerializerProvider.java:1443)
	at com.fasterxml.jackson.databind.SerializerProvider.findContentValueSerializer(SerializerProvider.java:777)
	at com.fasterxml.jackson.databind.ser.impl.PropertySerializerMap.findAndAddSecondarySerializer(PropertySerializerMap.java:90)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer._findAndAddDynamic(MapSerializer.java:1139)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer._findSerializer(MapSerializer.java:1248)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serializeOptionalFields(MapSerializer.java:853)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serializeWithoutTypeInfo(MapSerializer.java:760)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serialize(MapSerializer.java:720)
	at com.fasterxml.jackson.databind.ser.std.MapSerializer.serialize(MapSerializer.java:35)
	at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:728)
	at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:774)
	at com.fasterxml.jackson.databind.ser.BeanSerializer.serialize(BeanSerializer.java:178)
	at com.fasterxml.jackson.databind.ser.impl.IndexedListSerializer.serializeContents(IndexedListSerializer.java:119)
	at com.fasterxml.jackson.databind.ser.impl.IndexedListSerializer.serialize(IndexedListSerializer.java:79)
	at com.fasterxml.jackson.databind.ser.impl.IndexedListSerializer.serialize(IndexedListSerializer.java:18)
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:480)
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:400)
	at com.fasterxml.jackson.databind.ObjectWriter$Prefetch.serialize(ObjectWriter.java:1514)
	at com.fasterxml.jackson.databind.ObjectWriter.writeValue(ObjectWriter.java:1007)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase.writeTo(ProviderBase.java:647)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:242)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:227)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:85)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:61)
	... 54 more

My CLI log:

pulsarctl broker-stats mbeans 
[✖]  code: 400 reason: Invalid type definition for type `com.sun.management.internal.GcInfoCompositeData`: Failed to construct BeanSerializer for [simple type, class com.sun.management.internal.GcInfoCompositeData]: (java.lang.IllegalArgumentException) Failed to call `setAccess()` on Method 'getGcInfo' (of class `com.sun.management.internal.GcInfoCompositeData`) due to `java.lang.reflect.InaccessibleObjectException`, problem: Unable to make public com.sun.management.GcInfo com.sun.management.internal.GcInfoCompositeData.getGcInfo() accessible: module jdk.management does not "exports com.sun.management.internal" to unnamed module @c33b74f (through reference chain: java.util.ArrayList[0]->org.apache.pulsar.common.stats.Metrics["metrics"])

Modifications

Add --add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED to $OPTS in the pulsar.sh.

Documentation

doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nicoloboschi

Good work

Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit ae0f86b)

codelipenghui · 2023-01-19T09:18:06Z

@nodece Could you please help cherry-pick the release into branch-2.10

nodece · 2023-01-20T03:31:36Z

@codelipenghui See #19294.

[fix][cli] Fix mbeans to json

e63c63a

Signed-off-by: Zixuan Liu <nodeces@gmail.com>

nodece added this to the 2.11.0 milestone Sep 15, 2022

nodece requested review from eolivelli, mattisonchao, nicoloboschi, codelipenghui and Technoboy- September 15, 2022 15:13

nodece added area/cli release/2.11.0 release/2.11.1 and removed release/2.11.0 labels Sep 15, 2022

github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 15, 2022

coderzc approved these changes Sep 16, 2022

View reviewed changes

nicoloboschi approved these changes Sep 16, 2022

View reviewed changes

nodece added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 16, 2022

nodece merged commit ae0f86b into apache:master Sep 16, 2022

nodece added a commit that referenced this pull request Sep 19, 2022

[fix][cli] Fix mbeans to json (#17676)

43ada02

Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit ae0f86b)

nodece added the cherry-picked/branch-2.11 label Sep 19, 2022

lhotari mentioned this pull request Sep 19, 2022

lh reduce memory usage stub only mocks spies lhotari/pulsar#85

Closed

coderzc added the release/2.10.4 label Jan 9, 2023

nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 18, 2023

[fix][cli] Fix mbeans to json (apache#17676)

3b363ac

Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit ae0f86b)

nodece mentioned this pull request Jan 20, 2023

[fix][cli][branch-2.10] Fix mbeans to json #19294

Merged

4 tasks

codelipenghui added the cherry-picked/branch-2.10 label Feb 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix][cli] Fix mbeans to json #17676

[fix][cli] Fix mbeans to json #17676

nodece commented Sep 15, 2022

nicoloboschi left a comment

codelipenghui commented Jan 19, 2023

nodece commented Jan 20, 2023

[fix][cli] Fix mbeans to json #17676

[fix][cli] Fix mbeans to json #17676

Conversation

nodece commented Sep 15, 2022

Motivation

Modifications

Documentation

nicoloboschi left a comment

Choose a reason for hiding this comment

codelipenghui commented Jan 19, 2023

nodece commented Jan 20, 2023