[feat][broker][PIP-195] Implement delayed message bucket snapshot recover - part5 #18420
Conversation
coderzc
force-pushed
the
delayed_bucket_recover
branch
from
2ba0f47
to
b223ed4
Compare
coderzc
added
type/feature
| this.numberDelayedMessages = recoverBucketSnapshot(); | ||
| } | ||
|
|
||
| private long recoverBucketSnapshot() throws RuntimeException { |
There was a problem hiding this comment.
Is it better to add a method CompletableFuture<Void> initialize() to the DelayedDeliveryTracker to avoid blocking calls when creating the BucketDelayedDeliveryTracker instance
There was a problem hiding this comment.
It seems that we still need to block initialize method, when using DelayedDeliveryTrackerFactory to create DelayedEdeliverytracker
There was a problem hiding this comment.
Ok, we can just keep it here for now.
| int nextSegmentEntryId = nextSnapshotEntryIndex + 1; | ||
| loadMetaDataFuture.complete(nextSegmentEntryId); | ||
| }).exceptionally(ex -> { | ||
| loadMetaDataFuture.completeExceptionally(ex); |
There was a problem hiding this comment.
It looks like we can simplify the logic to avoid creating the loadMetaDataFuture.
It will make the code easy to read.
There was a problem hiding this comment.
It seems that he still needs loadMetaDataFuture, but I improve the code, make the code easy to read
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18420 +/- ##
============================================
+ Coverage 45.61% 46.28% +0.66%
+ Complexity 10728 10445 -283
============================================
Files 752 706 -46
Lines 72521 69078 -3443
Branches 7791 7398 -393
============================================
- Hits 33083 31973 -1110
+ Misses 35769 33509 -2260
+ Partials 3669 3596 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/Bucket.java
Show resolved
Hide resolved
...oker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/ImmutableBucket.java
Show resolved
Hide resolved
Master Issue: #16763
Motivation
#16763
Modifications
Implement delayed message index bucket snapshot recover
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#30