[improve][broker] In OverloadShedder, repeatedly filter local bundles

[lordcheng10]

Motivation

In the OverloadShedder#findBundlesForUnloading method, the local bundles are repeatedly filtered twice:

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/OverloadShedder.java

Lines 103 to 105 in dcf0b60

	loadData.getBundleDataForLoadShedding().entrySet().stream()
	.filter(e -> localData.getBundles().contains(e.getKey()))
	.map((e) -> {

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/OverloadShedder.java

Lines 117 to 119 in dcf0b60

	}).filter(e ->
	localData.getBundles().contains(e.getLeft())
	).sorted((e1, e2) -> {

Modifications

Remove duplicate filters.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: lordcheng10#40

[codelipenghui]

/pulsarbot run-failure-checks

[codecov-commenter]

Codecov Report

Merging #18463 (dc9190a) into master (fdf86d3) will increase coverage by 2.25%.
The diff coverage is 2.38%.

@@             Coverage Diff              @@
##             master   #18463      +/-   ##
============================================
+ Coverage     45.67%   47.92%   +2.25%     
+ Complexity    10075     9370     -705     
============================================
  Files           693      617      -76     
  Lines         67940    58471    -9469     
  Branches       7273     6090    -1183     
============================================
- Hits          31030    28022    -3008     
+ Misses        33333    27438    -5895     
+ Partials       3577     3011     -566     

Flag	Coverage Δ
unittests	47.92% <2.38%> (+2.25%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...adbalance/extensions/channel/ServiceUnitState.java	0.00% <0.00%> (ø)
...lance/extensions/channel/ServiceUnitStateData.java	0.00% <0.00%> (ø)
...ar/broker/loadbalance/extensions/models/Split.java	0.00% <0.00%> (ø)
...r/broker/loadbalance/extensions/models/Unload.java	0.00% <0.00%> (ø)
...ulsar/broker/loadbalance/impl/OverloadShedder.java	6.12% <0.00%> (+0.24%)	⬆️
...va/org/apache/pulsar/client/impl/ConsumerImpl.java	15.07% <0.00%> (-0.03%)	⬇️
...apache/pulsar/client/impl/ConsumerBuilderImpl.java	27.80% <50.00%> (+0.29%)	⬆️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java	21.62% <0.00%> (-45.95%)	⬇️
...apache/pulsar/client/impl/AutoClusterFailover.java	70.00% <0.00%> (-5.56%)	⬇️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java	60.64% <0.00%> (-1.39%)	⬇️
... and 149 more