[improve][broker] Use validateTopicOperationAsync methods in all cases

[lhotari]

Motivation

The validateTopicOperationAsync method should be used in all cases.

Modifications

• replace usage of validateTopicOperation with validateTopicOperationAsync in remaining code locations
• remove the unused validateTopicOperation methods

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#118

[lhotari]

related to #15043

[lhotari]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

Merging #19016 (f949639) into master (08591d9) will decrease coverage by 4.41%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master   #19016      +/-   ##
============================================
- Coverage     49.85%   45.43%   -4.42%     
- Complexity     8658     9083     +425     
============================================
  Files           500      629     +129     
  Lines         54930    59585    +4655     
  Branches       5867     6203     +336     
============================================
- Hits          27386    27074     -312     
- Misses        24464    29462    +4998     
+ Partials       3080     3049      -31     

Flag	Coverage Δ
unittests	45.43% <72.72%> (-4.42%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...g/apache/pulsar/broker/lookup/TopicLookupBase.java	52.29% <ø> (+1.46%)	⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java	57.41% <ø> (+1.75%)	⬆️
...pulsar/broker/admin/impl/PersistentTopicsBase.java	59.44% <72.72%> (+0.72%)	⬆️
...pache/pulsar/client/impl/CompactionReaderImpl.java	0.00% <0.00%> (-90.00%)	⬇️
...g/apache/pulsar/client/impl/RawBatchConverter.java	3.12% <0.00%> (-89.07%)	⬇️
.../pulsar/compaction/StrategicTwoPhaseCompactor.java	0.00% <0.00%> (-76.20%)	⬇️
...lsar/client/impl/RawBatchMessageContainerImpl.java	0.00% <0.00%> (-73.14%)	⬇️
.../pulsar/broker/service/SharedConsumerAssignor.java	3.70% <0.00%> (-64.82%)	⬇️
...lsar/broker/service/StickyKeyConsumerSelector.java	50.00% <0.00%> (-50.00%)	⬇️
...ion/buffer/metadata/TransactionBufferSnapshot.java	42.85% <0.00%> (-42.86%)	⬇️
... and 361 more