Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add lowerBoundarySheddingEnabled conf #19351

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

crossoverJie
Copy link
Member

Motivation

Make the lowerBoundarySheddingEnabled parameter active.

Modifications

add lowerBoundarySheddingEnabled config.

Verifying this change

  • Make sure that the change passes the CI checks.

  • Dependencies (add or upgrade a dependency)

  • The public API

  • The schema

  • The default values of configurations

  • The threading model

  • The binary protocol

  • The REST endpoints

  • The admin CLI options

  • The metrics

  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2023
@codelipenghui codelipenghui added this to the 3.0.0 milestone Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #19351 (9d1b4d6) into master (c17f355) will decrease coverage by 1.68%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19351      +/-   ##
============================================
- Coverage     64.33%   62.66%   -1.68%     
+ Complexity    26041    25550     -491     
============================================
  Files          1818     1818              
  Lines        133110   133100      -10     
  Branches      14644    14643       -1     
============================================
- Hits          85641    83405    -2236     
- Misses        39640    41985    +2345     
+ Partials       7829     7710     -119     
Flag Coverage Δ
inttests 24.91% <53.33%> (+0.04%) ⬆️
systests 25.71% <45.00%> (+0.13%) ⬆️
unittests 59.88% <73.33%> (-1.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/pulsar/broker/admin/AdminResource.java 73.83% <90.74%> (+3.56%) ⬆️
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 78.57% <100.00%> (-0.18%) ⬇️
...ain/java/org/apache/pulsar/broker/rest/Topics.java 0.00% <0.00%> (-100.00%) ⬇️
...lsar/client/impl/auth/AuthenticationDataBasic.java 0.00% <0.00%> (-100.00%) ⬇️
...ar/broker/stats/prometheus/ManagedLedgerStats.java 0.00% <0.00%> (-100.00%) ⬇️
...oker/stats/prometheus/PrometheusMetricStreams.java 0.00% <0.00%> (-100.00%) ⬇️
.../stats/prometheus/AggregatedSubscriptionStats.java 0.00% <0.00%> (-100.00%) ⬇️
...metheus/AggregatedTransactionCoordinatorStats.java 0.00% <0.00%> (-100.00%) ⬇️
...broker/stats/prometheus/TransactionAggregator.java 0.00% <0.00%> (-96.06%) ⬇️
...apache/pulsar/broker/web/ProcessHandlerFilter.java 0.00% <0.00%> (-83.34%) ⬇️
... and 202 more

@Technoboy- Technoboy- merged commit 785fb82 into apache:master Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants