[fix][test] Fix flaky test PersistentTopicTest.testGetReplicationClusters #19421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
Jason918,
nicoloboschi,
michaeljmarshall and
mattisonchao
nicoloboschi
reviewed
Feb 3, 2023
| @@ -2251,7 +2251,7 @@ private ByteBuf getMessageWithMetadata(byte[] data) { | |||
| @Test | |||
| public void testGetReplicationClusters() throws MetadataStoreException { | |||
| PersistentTopic topic = new PersistentTopic(successTopicName, ledgerMock, brokerService); | |||
| topic.initialize(); | |||
| topic.initialize().join(); | |||
There was a problem hiding this comment.
do we have a global timeout for single test?
There was a problem hiding this comment.
Yes we do.
mattisonchao
approved these changes
Feb 3, 2023
|
Thank you for taking care of this @lhotari! |
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
May 14, 2024
…ters (apache#19421) (cherry picked from commit 91c7ef7)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 14, 2024
…ters (apache#19421) (cherry picked from commit 91c7ef7)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 15, 2024
…ters (apache#19421) (cherry picked from commit 91c7ef7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19418
Motivation
PersistentTopicTest.testGetReplicationClusters fails consistently. PersistentTopic.initialize() is async and the test didn't wait for it's completion.
Modifications
replace
topic.initialize()withtopic.initialize().join()in PersistentTopicTest class.Documentation
docdoc-requireddoc-not-neededdoc-complete