[improve][ci] Replace handmade action to configure Gradle Enterprise #20218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
approved these changes
May 3, 2023
|
Thanks for taking care of this @clayburn! |
clayburn
commented
May 3, 2023
| @@ -721,11 +706,6 @@ jobs: | |||
| - name: Tune Runner VM | |||
| uses: ./.github/actions/tune-runner-vm | |||
|
|
|||
| - name: Configure Gradle Enterprise | |||
There was a problem hiding this comment.
I don't believe this was needed. This job does not seem to run a Maven build.
| @@ -1208,11 +1177,6 @@ jobs: | |||
| - name: Tune Runner VM | |||
| uses: ./.github/actions/tune-runner-vm | |||
|
|
|||
| - name: Configure Gradle Enterprise | |||
There was a problem hiding this comment.
I don't believe this was needed. This job does not seem to run a Maven build.
|
/pulsarbot rerun-failure-checks |
nodece
approved these changes
May 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #20218 +/- ##
=============================================
+ Coverage 37.66% 72.92% +35.25%
- Complexity 345 31952 +31607
=============================================
Files 1691 1868 +177
Lines 129004 138539 +9535
Branches 14071 15246 +1175
=============================================
+ Hits 48592 101028 +52436
+ Misses 74114 29469 -44645
- Partials 6298 8042 +1744
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After the PR #20187, the custom action at
.github/actions/gradle-enterprise/action.ymlsimply sets theGRADLE_ENTERPRISE_ACCESS_KEYenvironment variable. Since this is the only step performed by this action, it makes sense to remove it to simplify workflows.This was mentioned in the review for #20187: #20187 (review)
Modifications
gradle-enterpriseactionenvconfiguration to set theGRADLE_ENTERPRISE_ACCESS_KEYwhere neededVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: