[fix][test] ProxyWithoutServiceDiscoveryTest should enable authz #20348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/test
area/proxy
doc-not-needed
tisonkun
reviewed
May 18, 2023
| @@ -198,10 +196,10 @@ public void testDiscoveryService() throws Exception { | |||
| } | |||
|
|
|||
| protected final PulsarClient createPulsarClient(Authentication auth, String lookupUrl) throws Exception { | |||
| admin = spy(PulsarAdmin.builder().serviceHttpUrl(brokerUrlTls.toString()).tlsTrustCertsFilePath(TLS_TRUST_CERT_FILE_PATH) | |||
| .allowTlsInsecureConnection(true).authentication(auth).build()); | |||
There was a problem hiding this comment.
Why remove allowTlsInsecureConnection(true)?
There was a problem hiding this comment.
The test is documented as verifying end to end TLS, but this setting disables verification of the TLS certificate, which defeats the purpose of testing TLS.
Codecov Report
@@ Coverage Diff @@
## master #20348 +/- ##
=============================================
+ Coverage 34.55% 72.90% +38.34%
- Complexity 12631 31828 +19197
=============================================
Files 1614 1864 +250
Lines 126234 138281 +12047
Branches 13779 15172 +1393
=============================================
+ Hits 43622 100812 +57190
+ Misses 76999 29455 -47544
- Partials 5613 8014 +2401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 task
lhotari
pushed a commit
that referenced
this pull request
Jan 26, 2024
) (cherry picked from commit 2ebb379)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ProxyWithoutServiceDiscoveryTestis documented to verifye2e tls + Authentication + Authorization (client -> proxy -> broker). However, the TLS is insecure and authorization is disabled. This PR cleans up that test.Modifications
proxyRolesso authorization will pass.superUserRolesbecause the different certs have different CNs.Verifying this change
The test passes locally and the logs look right.
Documentation
doc-not-needed