[cleanup] Consolidate certs in broker (and some proxy) tests #20353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
area/test
type/cleanup
lhotari
pushed a commit
that referenced
this pull request
Jan 26, 2024
(cherry picked from commit d565c95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR builds on some of my recent changes here:
This PR removes several TLS certs that are unnecessary and replaces them with ones already created in the
tests/certificate-authoritydirectory.The goal is to simplify our test framework so that future updates to certificates are easy.
Modifications
tests/certificate-authoritycerts.testWebserviceServiceTlsconfigures the HTTP client for TLS and add some requirements on the broker to ensure that the client is connecting and providing TLS certs.Verifying this change
The change is fairly straight forward and the fact that the tests pass is key.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: michaeljmarshall#50