Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][misc] Use ubuntu 22.04 for Pulsar images #20475

Merged
merged 2 commits into from Jun 6, 2023

Conversation

codelipenghui
Copy link
Contributor

Motivation

Upgrade Ubuntu to 22.04 to fix some CVEs

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@codelipenghui codelipenghui self-assigned this Jun 2, 2023
@codelipenghui codelipenghui added this to the 3.1.0 milestone Jun 2, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 2, 2023
@codelipenghui codelipenghui reopened this Jun 2, 2023
@RobertIndie
Copy link
Member

We need to wait for python client 3.2.0, which contains this PR to fix the grpcio issue in the CI: https://github.com/apache/pulsar/actions/runs/5152766985/jobs/9279461880#step:11:10448

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #20475 (6b2ac60) into master (e220a5d) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20475      +/-   ##
============================================
+ Coverage     72.59%   72.88%   +0.29%     
- Complexity    31719    31893     +174     
============================================
  Files          1867     1867              
  Lines        138523   138575      +52     
  Branches      15204    15213       +9     
============================================
+ Hits         100555   101004     +449     
+ Misses        29955    29541     -414     
- Partials       8013     8030      +17     
Flag Coverage Δ
inttests 24.13% <ø> (+<0.01%) ⬆️
systests 24.95% <ø> (-0.03%) ⬇️
unittests 72.17% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 119 files with indirect coverage changes

@RobertIndie RobertIndie merged commit 12e6dd5 into apache:master Jun 6, 2023
43 checks passed
@codelipenghui codelipenghui deleted the penghui/ubuntu-22.04 branch June 6, 2023 03:26
@@ -82,7 +82,7 @@ flexible messaging model and an intuitive client API.</description>
<pulsar.broker.compiler.release>${maven.compiler.target}</pulsar.broker.compiler.release>
<pulsar.client.compiler.release>8</pulsar.client.compiler.release>

<pulsar.client.python.version>2.10.1</pulsar.client.python.version>
<pulsar.client.python.version>3.2.0</pulsar.client.python.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could have been in a separate PR. I had already lined one up #20467.

@RobertIndie
Copy link
Member

I move it to release/3.0.2. We may need an ML discussion for cherry-picking this PR to other version branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants