[fix][io][branch-3.0] Not restart instance when kafka source poll exception. #20818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
type/bug
Technoboy-
approved these changes
Jul 17, 2023
poorbarcode
reviewed
Jul 17, 2023
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaPushSource.java
Show resolved
Hide resolved
RobertIndie
reviewed
Jul 17, 2023
pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java
Show resolved
Hide resolved
poorbarcode
approved these changes
Jul 17, 2023
RobertIndie
approved these changes
Jul 17, 2023
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 13, 2024
…eption. (apache#20818) (cherry picked from commit 9d580b4)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…eption. (apache#20818) (cherry picked from commit 9d580b4)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…eption. (apache#20818) (cherry picked from commit 9d580b4)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…eption. (apache#20818) (cherry picked from commit 9d580b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When Kafka source poll message exception, it will throw it to the function framework, and not trigger the restart function instance.
#20795 uses a new method on PulsarSource #20791 to fix it on master branch. To maintain compatibility, we can't cherry-pick it to the historical version, so the class is implemented in the Kafka source connector.
Modifications
KafkaPushSourceon Kafka source connector.notifyErrorto report the exception to the io connector framework.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository