-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][io] Add notifyError method on PushSource. #20791
Conversation
6315ef7
to
a8af71f
Compare
Codecov Report
@@ Coverage Diff @@
## master #20791 +/- ##
=============================================
+ Coverage 33.44% 73.09% +39.65%
- Complexity 12097 32115 +20018
=============================================
Files 1612 1867 +255
Lines 126568 139040 +12472
Branches 13824 15294 +1470
=============================================
+ Hits 42328 101629 +59301
+ Misses 78686 29346 -49340
- Partials 5554 8065 +2511
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@shibd Would this PR change the interface for the ecosystem component? If yes, I think we shouldn't add it to branch-3.0. |
Thanks for your reminder. I remove the |
We probably also need this in Sink connector to capture error happens when the actual write action happens |
Sure, I'll research a way to do it. |
Motivation
If one source connector extends
PushSource
. An exception was encountered when this source connector consumed the source system data, it had no way to notify the function framework to restart this connector.Modifications
BatchPushSource
logic toAbstractPushSource
.PushSource
to extendsAbstractPushSource
to extend a new method(notifyError).Verifying this change
PushSourceTest
to cover it.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository