-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker]Check that the super user role is in the MultiRolesTokenAuthorizationProvider plugin #20939
[fix][broker]Check that the super user role is in the MultiRolesTokenAuthorizationProvider plugin #20939
Conversation
@tuteng Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test for this? :)
Done |
Codecov Report
@@ Coverage Diff @@
## master #20939 +/- ##
=============================================
+ Coverage 33.53% 73.12% +39.58%
- Complexity 12174 32249 +20075
=============================================
Files 1621 1875 +254
Lines 126919 139406 +12487
Branches 13851 15329 +1478
=============================================
+ Hits 42561 101935 +59374
+ Misses 78745 29418 -49327
- Partials 5613 8053 +2440
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…AuthorizationProvider plugin (apache#20939) Fixed apache#20938
…AuthorizationProvider plugin (apache#20939) Fixed apache#20938
My repo pr AmateurEvents#35
Fixes #20938
Main Issue: #20938
PIP: #xyz
Motivation
Support super user role check
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: