Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker]Check that the super user role is in the MultiRolesTokenAuthorizationProvider plugin #20939

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Aug 7, 2023

My repo pr AmateurEvents#35

Fixes #20938

Main Issue: #20938

PIP: #xyz

Motivation

Support super user role check

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@tuteng Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Aug 7, 2023
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this? :)

@tuteng
Copy link
Member Author

tuteng commented Aug 10, 2023

Could you please add a test for this? :)

Done

@codecov-commenter
Copy link

Codecov Report

Merging #20939 (142cb79) into master (9862884) will increase coverage by 39.58%.
The diff coverage is 40.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20939       +/-   ##
=============================================
+ Coverage     33.53%   73.12%   +39.58%     
- Complexity    12174    32249    +20075     
=============================================
  Files          1621     1875      +254     
  Lines        126919   139406    +12487     
  Branches      13851    15329     +1478     
=============================================
+ Hits          42561   101935    +59374     
+ Misses        78745    29418    -49327     
- Partials       5613     8053     +2440     
Flag Coverage Δ
inttests 24.14% <0.00%> (-0.14%) ⬇️
systests 25.07% <0.00%> (?)
unittests 72.42% <40.00%> (+40.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rization/MultiRolesTokenAuthorizationProvider.java 60.43% <40.00%> (+60.43%) ⬆️

... and 1521 files with indirect coverage changes

@tuteng tuteng merged commit e41883e into apache:master Aug 11, 2023
45 checks passed
Technoboy- pushed a commit that referenced this pull request Aug 17, 2023
Technoboy- pushed a commit that referenced this pull request Aug 17, 2023
merlimat pushed a commit that referenced this pull request Oct 11, 2023
Technoboy- pushed a commit that referenced this pull request Oct 30, 2023
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants