Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][proxy] When adding new brokers resolve the DNS name more quickly #21207

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[improve][proxy] When adding new brokers resolve the DNS name more quickly #21207

merged 1 commit into from
Sep 20, 2023

Conversation

frankjkelly
Copy link
Contributor

@frankjkelly frankjkelly commented Sep 19, 2023

Fixes #21206

Motivation

When autoscaling brokers, the current default negative ttl is 10 seconds so it might take up to 10 seconds before the proxy realizes the broker was available and this could lead to errors at the pulsar client if the operation timeout was below 10 seconds .
Similarly this should have positive impact for broker --> bookie (when new bookies are autoscaling).

Modifications

Added a line to the Dockerfile to override the negative.ttl in the java.security file

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@frankjkelly frankjkelly changed the title [Bug][All] When adding new brokers resolve the DNS name more quickly [Bug][Proxy] When adding new brokers resolve the DNS name more quickly Sep 19, 2023
@github-actions
Copy link

@frankjkelly Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 19, 2023
@frankjkelly
Copy link
Contributor Author

@merlimat merlimat added this to the 3.2.0 milestone Sep 19, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun changed the title [Bug][Proxy] When adding new brokers resolve the DNS name more quickly [Bug][proxy] When adding new brokers resolve the DNS name more quickly Sep 19, 2023
@tisonkun
Copy link
Member

I suggest this to be an improvement rather than a bugfix?

@frankjkelly frankjkelly changed the title [Bug][proxy] When adding new brokers resolve the DNS name more quickly [Improvement][proxy] When adding new brokers resolve the DNS name more quickly Sep 19, 2023
@frankjkelly
Copy link
Contributor Author

I suggest this to be an improvement rather than a bugfix?

Makes sense - done.

@tisonkun tisonkun changed the title [Improvement][proxy] When adding new brokers resolve the DNS name more quickly [improve][proxy] When adding new brokers resolve the DNS name more quickly Sep 19, 2023
@tisonkun
Copy link
Member

Merging..

Thanks for your contribution!

@tisonkun tisonkun merged commit e5b0f17 into apache:master Sep 20, 2023
53 of 59 checks passed
@frankjkelly
Copy link
Contributor Author

Merging..

Thanks for your contribution!

Thanks @tisonkun - if I wanted to backport this change to active branches (e.g. 3.1/3.0/2.11/2.10 etc) does that make sense?

@tisonkun
Copy link
Member

@frankjkelly thanks for your question!

I'd hear from @codelipenghui @Technoboy- & @eolivelli.

Generally, I'm OK to backport this patch. For the target branches, 3.0 and 3.1 is undoubtedly supported, but I'm not sure for 2.10 and 2.11.

The best way for such discussion would be that you send an email to the dev@pulsar.apache.org mailing list. Subscribe following the instruction here, and refer to previous discussions like this one.

@lhotari lhotari mentioned this pull request Feb 15, 2024
14 tasks
@nodece
Copy link
Member

nodece commented Feb 18, 2024

I think this is a bug, and I would like to backport this patch to the branch-3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Proxy DNS resolution failure when brokers are autoscaling
5 participants