[fix][test] Fix flaky test NarUnpackerTest #21328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduce number of processes from 10 to 5 - reduce the number of files in the sample zip from 10000 to 5000 - make the test use less CPU resources so that it will run in CI with constrained resources - make JIT compiler stop at C1 - disable JMX registration in Log4j2 which showed up in profiling - increase max heap size from 64MB to 96MB to give more head room for GC
4 tasks
poorbarcode
approved these changes
Oct 9, 2023
|
Since |
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
lhotari
added a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit e76a86e) # Conflicts: # pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java
vinayakmalik95
pushed a commit
to tmdc-io/pulsar
that referenced
this pull request
Oct 12, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2023
(cherry picked from commit e76a86e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit e76a86e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21291
Fixes #21285
Motivation
NarUnpackerTest is really flaky. See the above isues that this PR fixes.
When investigating the problem, I was able to reproduce the issue by running the test within Docker with constrained resources. There's a 30 second timeout in the shouldExtractFilesOnceInDifferentProcess test for the 10 different processes to complete. This takes much longer since each process uses significant amount of CPU. The fix is to reduce the CPU consumption by reducing the test data size, reducing the number of processes and tuning the JVM parameters for the forked processes.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete