[fix][broker] Fix setReplicatedSubscriptionStatus incorrect behavior #21510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enableReplicatedSubscriptions.
Technoboy-
approved these changes
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #21510 +/- ##
=============================================
+ Coverage 33.39% 73.23% +39.84%
- Complexity 12194 32664 +20470
=============================================
Files 1638 1892 +254
Lines 127949 140694 +12745
Branches 13952 15476 +1524
=============================================
+ Hits 42733 103043 +60310
+ Misses 79564 29550 -50014
- Partials 5652 8101 +2449
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
approved these changes
Nov 11, 2023
| @@ -178,6 +186,21 @@ protected void setup() throws Exception { | |||
| urlTls3 = new URL(pulsar3.getWebServiceAddressTls()); | |||
| admin3 = PulsarAdmin.builder().serviceHttpUrl(url3.toString()).build(); | |||
|
|
|||
| // Start region 4 | |||
There was a problem hiding this comment.
Suggested change
| // Start region 4 | |
| // Start region 4, the Broker of cluster-4 will disable the feature "ReplicatedSubscriptions" |
nborisov
pushed a commit
to nborisov/pulsar
that referenced
this pull request
Nov 13, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Nov 23, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Nov 28, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Dec 3, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Dec 4, 2023
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21506
Motivation
fix setReplicatedSubscriptionStatus Incorrect behavior, when unenable enableReplicatedSubscriptions.
Modifications
when unenable enableReplicatedSubscriptions, set replicatedSubscription status to ture, should throw an exception.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: