[fix][broker] Record GeoPersistentReplicator.msgOut before producer#sendAsync #21673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endAsync Signed-off-by: Zixuan Liu <nodeces@gmail.com>
|
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
Dec 6, 2023
|
/pulsarbot rerun-failure-checks |
liudezhi2098
approved these changes
Dec 7, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Dec 8, 2023
…endAsync (#21673) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Technoboy-
added
release/3.1.2
cherry-picked/branch-3.1
and removed
release/3.1.3
labels
Technoboy-
pushed a commit
that referenced
this pull request
Dec 14, 2023
…endAsync (#21673) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…endAsync (apache#21673) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
…endAsync (apache#21673) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GeoPersistentReplicator.msgOutmetric records the message output data from the local cluster to the remote cluster. Right now, this metric has been updated before getting the shema. If it fails, we don't send the message to the remote cluster, so I don't think the metric should be updated.GeoPersistentReplicator.msgOutshould be recorded beforeproducer#sendAsync.Modifications
Move
msgOut.recordEvent(headersAndPayload.readableBytes());beforeproducer#sendAync.Documentation
docdoc-requireddoc-not-neededdoc-complete