[fix][broker] Fix typo in the config key #21690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/PIP
doc-not-needed
Merged
5 tasks
coderzc
added
type/bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21690 +/- ##
=============================================
+ Coverage 34.49% 73.38% +38.89%
- Complexity 12116 32760 +20644
=============================================
Files 1716 1893 +177
Lines 131152 140753 +9601
Branches 14327 15503 +1176
=============================================
+ Hits 45236 103291 +58055
+ Misses 79828 29362 -50466
- Partials 6088 8100 +2012
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlimat
approved these changes
Dec 7, 2023
merlimat
pushed a commit
that referenced
this pull request
Dec 7, 2023
merlimat
pushed a commit
that referenced
this pull request
Dec 7, 2023
coderzc
added a commit
that referenced
this pull request
Dec 14, 2023
(cherry picked from commit 822b7f4)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 20, 2023
coderzc
added a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit 822b7f4)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Feb 23, 2024
(cherry picked from commit 822b7f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#21578 (comment)
Since we haven't had a release since #21578 merged, so we can just fix it.
Modifications
topicCompactionRemainNullKey->topicCompactionRetainNullKey.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: