Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] PIP-335: Add support Oxia as a metadata store #22007

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

merlimat
Copy link
Contributor

Motivation

Add support for Oxia (https://github.com/streamnative/oxia) as a possible metadata store backed.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added type/feature The PR added a new feature or issue requested a new feature ready-to-test labels Jan 31, 2024
@merlimat merlimat added this to the 3.3.0 milestone Jan 31, 2024
@merlimat merlimat self-assigned this Jan 31, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jan 31, 2024
@merlimat merlimat changed the title [feature] Add support Oxia as a metadata store [feat] Add support Oxia as a metadata store Jan 31, 2024
@nodece
Copy link
Member

nodece commented Jan 31, 2024

This PR seems to require a PIP, could you make a PIP?

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BewareMyPower
Copy link
Contributor

And I agree with @nodece that we need a PIP for introducing a new plugin to the broker side.

@merlimat
Copy link
Contributor Author

Ok, I can create a PIP, similar to Etcd support.

@merlimat merlimat changed the title [feat] Add support Oxia as a metadata store [feat] PIP-335: Add support Oxia as a metadata store Jan 31, 2024
@merlimat
Copy link
Contributor Author

merlimat commented Feb 1, 2024

@nodece @BewareMyPower PIP created #22009

https://lists.apache.org/thread/bmlo879sm1dd9wkgqzhb7fzlppdzm3yl

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

Looking forward to see it in action

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pom.xml Show resolved Hide resolved
@merlimat merlimat merged commit a83e9ed into apache:master Feb 7, 2024
48 of 49 checks passed
@merlimat merlimat deleted the oxia branch February 7, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants