[improve] [broker] Avoid repeated Read-and-discard when using Key_Shared mode #22245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Mar 12, 2024
Fixed, thanks |
poorbarcode
force-pushed
the
fix/repeat_read_in_key_shared_mode
branch
from
4f5a284
to
326c0cc
Compare
|
rebase master |
lhotari
added
release/3.2.3
release/3.0.5
and removed
release/3.0.4
release/3.2.2
labels
poorbarcode
force-pushed
the
fix/repeat_read_in_key_shared_mode
branch
from
326c0cc
to
ea66ce1
Compare
|
rebase master |
.../apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/api/KeySharedSubscriptionTest.java
Outdated
Show resolved
Hide resolved
poorbarcode
force-pushed
the
fix/repeat_read_in_key_shared_mode
branch
from
d887253
to
7fb0a89
Compare
codelipenghui
approved these changes
Mar 29, 2024
.../apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
poorbarcode
added a commit
that referenced
this pull request
Mar 29, 2024
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Apr 1, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 15, 2024
…red mode (apache#22245) (cherry picked from commit e34ea62) (cherry picked from commit 5b37e84)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…red mode (apache#22245) (cherry picked from commit e34ea62) (cherry picked from commit 5b37e84)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 17, 2024
…red mode (apache#22245) (cherry picked from commit e34ea62) (cherry picked from commit 5b37e84)
4 tasks
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 19, 2024
…red mode (apache#22245) (cherry picked from commit e34ea62) (cherry picked from commit 5b37e84)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2024
…red mode (apache#22245) (cherry picked from commit e34ea62) (cherry picked from commit 5b37e84)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
Key_Sharedsubscription, the broker may discard a part of the result reading from BK to avoid breaking the order of consumption, but this may cause repeated Read-and-discard, which wastes a lot of BK traffic.consumer.maxReadPositionYou can reproduce the issue by
testNoRepeatedReadAndDiscardModifications
Before reading the BK, filter out the positions that will be discarded.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x